public
nobgit
read
NobMail
Based on mailcow: dockerized
Languages
Repository composition by tracked source files.
PHP
49%
JavaScript
35%
HTML
9%
CSS
4%
Shell
2%
Python
1%
Lua
0%
Perl
0%
Ruby
0%
SCSS
0%
Create file
Wiki Documentation
Clone
https://nobgit.com/orgs/nobgit/nobmail.git
ssh://[email protected]:2222/orgs/nobgit/nobmail.git
Commit
🛠fix: Language detection
905993d6
data/web/inc/prerequisites.inc.php | 48 +++++++++++++++++++++++++++++++++---
data/web/inc/vars.inc.php | 2 +-
data/web/templates/base.twig | 2 +-
data/web/templates/index.twig | 2 +-
helper-scripts/add-new-lang-keys.php | 2 +-
helper-scripts/check_translations.rb | 2 +-
6 files changed, 49 insertions(+), 9 deletions(-)
Diff
diff --git a/data/web/inc/prerequisites.inc.php b/data/web/inc/prerequisites.inc.php
index 5800e570..0e294bd0 100644
--- a/data/web/inc/prerequisites.inc.php
+++ b/data/web/inc/prerequisites.inc.php
@@ -195,10 +195,50 @@ require_once $_SERVER['DOCUMENT_ROOT'] . '/inc/sessions.inc.php';
// Set language
if (!isset($_SESSION['mailcow_locale']) && !isset($_COOKIE['mailcow_locale'])) {
if ($DETECT_LANGUAGE && isset($_SERVER['HTTP_ACCEPT_LANGUAGE'])) {
- $header_lang = strtolower($_SERVER['HTTP_ACCEPT_LANGUAGE']);
- if (array_key_exists($header_lang, $AVAILABLE_LANGUAGES)) {
- $_SESSION['mailcow_locale'] = $header_lang;
+ preg_match_all('/([a-z]{1,8}-[a-z]{1,8})\s*(;\s*q\s*=\s*(1|0\.[0-9]+))?/i', $_SERVER['HTTP_ACCEPT_LANGUAGE'], $lang_parse);
+ // preg_match_all('/([a-z]{1,8}(-[a-z]{1,8})*)\s*(;\s*q\s*=\s*(1|0\.[0-9]+))?/i', $_SERVER['HTTP_ACCEPT_LANGUAGE'], $lang_parse);
+
+ error_log(print_r($lang_parse, TRUE));
+ error_log(print_r(substr($_SERVER['HTTP_ACCEPT_LANGUAGE'], 0, 2), TRUE));
+ error_log(print_r('asdasdasdasdasdasd', TRUE));
+
+
+ $langs = $lang_parse[1];
+ $ranks = $lang_parse[3];
+
+ // (create an associative array 'language' => 'preference')
+ $lang2pref = array();
+ for ($i=0; $i<count($langs); $i++) {
+ $lang2pref[strtolower($langs[$i])] = (float) (!empty($ranks[$i]) ? $ranks[$i] : 1);
}
+
+ // (comparison function for uksort)
+ $cmpLangs = function ($a, $b) use ($lang2pref) {
+ if ($lang2pref[$a] > $lang2pref[$b])
+ return -1;
+ elseif ($lang2pref[$a] < $lang2pref[$b])
+ return 1;
+ elseif (strlen($a) > strlen($b))
+ return -1;
+ elseif (strlen($a) < strlen($b))
+ return 1;
+ else
+ return 0;
+ };
+
+ // sort the languages by prefered language and by the most specific region
+ uksort($lang2pref, $cmpLangs);
+
+ foreach ($lang2pref as $lang => $q) {
+ error_log(print_r($lang, TRUE));
+ if (array_key_exists($lang, $AVAILABLE_LANGUAGES)) {
+ $_SESSION['mailcow_locale'] = $lang;
+ break;
+ }
+ }
+
+ error_log(print_r($lang2pref, TRUE));
+ error_log(print_r($_SESSION['mailcow_locale'], TRUE));
}
else {
$_SESSION['mailcow_locale'] = strtolower(trim($DEFAULT_LANG));
@@ -215,7 +255,7 @@ if (isset($_GET['lang']) && array_key_exists($_GET['lang'], $AVAILABLE_LANGUAGES
/*
* load language
*/
-$lang = json_decode(file_get_contents($_SERVER['DOCUMENT_ROOT'] . '/lang/lang.en.json'), true);
+$lang = json_decode(file_get_contents($_SERVER['DOCUMENT_ROOT'] . '/lang/lang.en-gb.json'), true);
$langFile = $_SERVER['DOCUMENT_ROOT'] . '/lang/lang.'.$_SESSION['mailcow_locale'].'.json';
if(file_exists($langFile)) {
diff --git a/data/web/inc/vars.inc.php b/data/web/inc/vars.inc.php
index d3419457..7d319488 100644
--- a/data/web/inc/vars.inc.php
+++ b/data/web/inc/vars.inc.php
@@ -76,7 +76,7 @@ $autodiscover_config = array(
$DETECT_LANGUAGE = true;
// Change default language
-$DEFAULT_LANG = 'en';
+$DEFAULT_LANG = 'en-gb';
// Available languages
// https://www.iso.org/obp/ui/#search
diff --git a/data/web/templates/base.twig b/data/web/templates/base.twig
index bd1e16d2..ed0d7b05 100644
--- a/data/web/templates/base.twig
+++ b/data/web/templates/base.twig
@@ -32,7 +32,7 @@
<ul class="nav navbar-nav navbar-right">
{% if mailcow_locale %}
<li class="dropdown{% if available_languages|length == 1 %}lang-link-disabled{% endif %}">
- <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-expanded="false"><span class="flag-icon flag-icon-{{ mailcow_locale }}"></span><span class="caret"></span></a>
+ <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-expanded="false"><span class="flag-icon flag-icon-{{ mailcow_locale[-2:] }}"></span><span class="caret"></span></a>
<ul class="dropdown-menu" role="menu">
{% for key, val in available_languages %}
<li{% if mailcow_locale == key %} class="active"{% endif %}>
diff --git a/data/web/templates/index.twig b/data/web/templates/index.twig
index 653b65c4..38eeed00 100644
--- a/data/web/templates/index.twig
+++ b/data/web/templates/index.twig
@@ -45,7 +45,7 @@
</div>
{% if not oauth2_request %}
<button type="button" {% if available_languages|length == 1 %}disabled="true"{% endif %} class="btn btn-xs-lg btn-default pull-right dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
- <span class="flag-icon flag-icon-{{ mailcow_locale }}"></span> <span class="caret"></span>
+ <span class="flag-icon flag-icon-{{ mailcow_locale[-2:] }}"></span> <span class="caret"></span>
</button>
<ul class="dropdown-menu pull-right login">
{% for key, val in available_languages %}
diff --git a/helper-scripts/add-new-lang-keys.php b/helper-scripts/add-new-lang-keys.php
index 19010f86..1f5f377a 100644
--- a/helper-scripts/add-new-lang-keys.php
+++ b/helper-scripts/add-new-lang-keys.php
@@ -26,7 +26,7 @@ if(empty($targetLang)) {
}
// load master lang
-$masterLang = file_get_contents(__DIR__.'/../data/web/lang/lang.en.json');
+$masterLang = file_get_contents(__DIR__.'/../data/web/lang/lang.en-gb.json');
$masterLang = json_decode($masterLang, true);
// load target lang
diff --git a/helper-scripts/check_translations.rb b/helper-scripts/check_translations.rb
index af4da1c2..a8bfb5a0 100755
--- a/helper-scripts/check_translations.rb
+++ b/helper-scripts/check_translations.rb
@@ -1,6 +1,6 @@
#!/usr/bin/env ruby
-MASTER="en"
+MASTER="en-gb"
DIR = "#{__dir__}/.."